fix(tray): change the order in which the identifier for blacklist and pinned items is taken#2501
Open
lombervid wants to merge 2 commits intonoctalia-dev:mainfrom
Open
fix(tray): change the order in which the identifier for blacklist and pinned items is taken#2501lombervid wants to merge 2 commits intonoctalia-dev:mainfrom
blacklist and pinned items is taken#2501lombervid wants to merge 2 commits intonoctalia-dev:mainfrom
Conversation
…nd `pinned` items is taken - replace property `name` with `title` - change order from `tooltipTitle`/`name`/`id` to `id`/`title`/`tooltipTitle`
add `wildCardMatch` function in `TrayMenu` to check matches with regex patterns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Motivation
Currently the identifier for the
blacklistandpinneditems in the tray widget is being taken from the propertiestooltipTitle/name/id, in that order of precedence. TakingtooltipTitleas the first option is not ideal since that property seems to be dynamic and changes depending on certain conditions.For example:
Bluetooth Disabled/Bluetooth Enabled)[DATABASE_NAME] - KeePassXC)Because of this:
blacklistrulesSo, the order was changed to
id/title/tooltipTitle.nameproperty was replaced withtitlesince it doesn't seem to be a valid property.wildCardMatchfunction was added inTrayMenu.qmlto keep consistency on how pinned items are verified (since in bothTray.qmlandTrayDrawerPanel.qmlawildCardMatchfunction is used to check for matches with regex patterns).Type of Change
Mark the relevant option with an "x".
Testing
blacklistfield and verify the apps are omittedPin/Unpin Applicationis working correctlyidvalue of the app, i.e,keepassxc/*KeePass*forKeePassXC) in thepinneditems in the settingsUnpin Applicationbutton instead ofPin ApplicationUnpin Applicationbutton removes the entry from the settingsScreenshots / Videos
2026-04-19.17-43-41.mp4
Checklist
Additional Notes
The only app that I've seen so far that could have a problem trying to blacklist with this approach is Discord, whose ID is
chrome_status_icon_1in my case. (Pinning it using thePin Applicationbutton works fine) .